Committing Micro-Manager changes

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Committing Micro-Manager changes

Mahesh Kakuturu
Hello community,

I am going to implement the changes to Micro-manager 1.4 code base to support 32 bit floating point GRAY scale images for the community. Do you accept the changes to push-in to source code if I successfully implement this feature. Or do I need to work on this feature only on 2.0 code base to accept the changes. I believe it's easy for you to port the changes that are going to made in 1.4 to 2.0 if you want to support the GRAY32 type in both the versions.

I did necessary modifications to support 32 bit floating point gray scale in adapter side and Java side. Now I am pulling my hair to modify the changes in MMCore part where the intermediate compiler files are existed. I am having difficulty in understanding this code. Hopefully, can overcome this by spending some more time or with your help.

--
Best Regards,
Mahesh Kakuturu
Sr. Software Engineer
Angstrom Science, Inc.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
micro-manager-general mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/micro-manager-general
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Committing Micro-Manager changes

JonD
Administrator
This post has NOT been accepted by the mailing list yet.
Hello Mahesh,

Mahesh Kakuturu wrote
I am going to implement the changes to Micro-manager 1.4 code base to
support 32 bit floating point GRAY scale images for the community. Do you
accept the changes to push-in to source code if I successfully implement
this feature. Or do I need to work on this feature only on 2.0 code base to
accept the changes. I believe it's easy for you to port the changes that
are going to made in 1.4 to 2.0 if you want to support the GRAY32 type in
both the versions.

I did necessary modifications to support 32 bit floating point gray scale
in adapter side and Java side. Now I am pulling my hair to modify the
changes in MMCore part where the intermediate compiler files are existed. I
am having difficulty in understanding this code. Hopefully, can overcome
this by spending some more time or with your help.
I can't help you with the specific task of modifying the code, but you can find instructions for submitting code on this thread: http://micro-manager.3463995.n2.nabble.com/MM2-Source-Code-td7587529.html.  In my experience patches are welcome and expeditiously applied by the maintainers.

In the past when I've submitted patches to the core I've only needed to modify the file MMCore.cpp.  Maybe there is something extra you need to do, but I can tell you there are files related to interfacing the core with the Java layer (and Python) that are auto-generated so you probably don't need to modify those.

Jon

-------------------------------------------
Jon Daniels
Applied Scientific Instrumentation
29391 West Enid Rd, Eugene, OR 97402
Phone: (541) 461-8181 x118
-------------------------------------------
Loading...